12 Commits

Author SHA1 Message Date
475888ad01 BREADCRUMBS 2026-04-03 15:03:26 -04:00
Nathan Castaldi
042ce34837
feat(workday): add identity drift mismatch scanners and MCP tool coverage (#2)
* expanded the Workday fixture data in data.py so each mock worker now carries the paired source attributes needed for upcoming drift checks: Workday title, AD title, Workday cost center context, AD department, legal name, preferred name, AD display name, and AD enabled state. Existing fields used by the current tools were preserved, so this was a schema expansion rather than a behavioral change.

* added a dedicated data-layer detector in data.py named scan_status_reconciliation_mismatches(). It scans the current mock worker set and flags the exact mismatch you asked for: status == "Terminated" in Workday while ad_enabled == True in AD. The response shape follows the existing manager-scan pattern with scan_summary plus a mismatches list.

* exposed the status reconciliation detector as a dedicated MCP tool in server.py by importing the new data-layer function and adding scan_status_reconciliation(). This keeps the existing architecture intact: the server remains a thin wrapper, and the scan logic stays in data.py.

* added scan_job_title_mismatches() to data.py. It compares workday_title against ad_title for each worker and returns the same structured pattern as the other detectors: scan_summary plus a mismatches list with both source values, a deterministic mismatch type, and severity.

* exposed the title detector as a dedicated MCP tool in server.py by importing the new data-layer function and adding scan_job_title_drift(). The server is still acting as a thin wrapper over the detector in data.py.

* added scan_department_drift() to data.py. It compares the Workday department context against the AD department string and includes the Workday cost center in each mismatch record so the drift is easier to interpret during reconciliation.

* exposed the department detector as a dedicated MCP tool in server.py by adding scan_department_mismatches(), which delegates to the detector in data.py. The existing tool structure remains unchanged.

* added scan_name_variance() to data.py. The detector normalizes legal, preferred, and AD display names, allows reasonable preferred-name usage, and flags cases where the AD display name no longer aligns to either the legal or preferred first name plus the legal last name.

* exposed the name-variance detector as a dedicated MCP tool in server.py by adding scan_name_variance_mismatches(), which delegates to the detector in data.py. The server still remains a thin wrapper layer.

* I’m checking the Workday project’s current test layout first so I can add one focused test file that matches the existing environment and runner configuration.

Searched for files matching `**/Workday/workday-mcp/**/*`, 3 matches

The Workday runtime is even thinner than the planning docs imply: there’s no test package or local pyproject in that folder yet. I’m checking the parent Workday artifacts and the root repo config so the new tests land in a runnable location.

Read [](file:///c%3A/Users/castn1.CORP/OneDrive%20-%20Wheels/Repos/mcp_servers/Workday/workday-mcp)

Searched for files matching `**/pyproject.toml`, 1 match

Searched for files matching `**/pytest.ini`, no matches

Searched for files matching `**/tox.ini`, no matches

I’ve confirmed there’s no existing Workday test harness, so I’m borrowing the minimal testing conventions from the Identity project before I add one focused detector test file.

Searched for regex `pytest|testpaths|pythonpath` (`**/Identity/pyproject.toml`), 2 results

Read [](file:///c%3A/Users/castn1.CORP/OneDrive%20-%20Wheels/Repos/mcp_servers/Identity/pyproject.toml)

Fetching Python environment information
Completed with input: {
  "resourcePath": "c:\\Users\\castn1.CORP\\OneDrive - Wheels\\Repos\\mcp_servers\\Workday\\workday-mcp"
}

I have enough context to add the test file. The Workday virtual environment does not currently include `pytest`, so I’m installing the minimal test dependency now and then I’ll add a single focused test module for the new detectors and wrappers.

Installing pytest>=7.4.0 in Python 3.13.12 (.venv)
Completed with input: {
  "resourcePath": "c:\\Users\\castn1.CORP\\OneDrive - Wheels\\Repos\\mcp_servers\\Workday\\workday-mcp",
  "packageList": [
    "pytest>=7.4.0"
  ]
}

Completed: *Expose status MCP tool* (11/18)

The test dependency is installed. I’m adding one focused Workday test module now for the four detectors and their MCP wrapper functions.

Generating patch (95 lines) in [](file:///c%3A/Users/castn1.CORP/OneDrive%20-%20Wheels/Repos/mcp_servers/Workday/workday-mcp/tests/test_mismatch_scans.py)

```

```
The test file is in place. I’m running only that focused test module now and checking for any file errors introduced by the new coverage.

Ran terminal command:  cd "/c/Users/castn1.CORP/OneDrive - Wheels/Repos/mcp_servers/Workday/workday-mcp" && "c:/Users/castn1.CORP/OneDrive - Wheels/Repos/mcp_servers/Workday/workday-mcp/.venv/Scripts/python.exe" -m pytest tests/test_mismatch_scans.py -q

Checked [](file:///c%3A/Users/castn1.CORP/OneDrive%20-%20Wheels/Repos/mcp_servers/Workday/workday-mcp/tests/test_mismatch_scans.py), [](file:///c%3A/Users/castn1.CORP/OneDrive%20-%20Wheels/Repos/mcp_servers/Workday/workday-mcp/server.py), [](file:///c%3A/Users/castn1.CORP/OneDrive%20-%20Wheels/Repos/mcp_servers/Workday/workday-mcp/lib/data.py), no problems found

[[ PROCESSING: Mode=NORMAL_MODE | Intent=Report completion of the focused test-coverage step and pause before any optional documentation/status update | Strategy=Summarize the new test file and the verification result, then wait for NEXT ]]

Step 10 is complete on `feat/workday-mismatch-expansion`.

I added focused pytest coverage in test_mismatch_scans.py for the four new detectors and their MCP wrappers:
`scan_status_reconciliation_mismatches`, `scan_job_title_mismatches`, `scan_department_drift`, `scan_name_variance`, plus the corresponding server functions in server.py.

Verification passed. Running the focused test module succeeded with `8 passed in 0.49s`, and there are no reported errors in test_mismatch_scans.py, server.py, or data.py.

Reply exactly with:

NEXT

After that, I’ll do the final atomic step: update status or planning documentation only where needed to reflect the newly implemented mismatch coverage, then I’ll close the session with a summary, snapshot draft, and a Conventional Commit suggestion for your branch review flow.

Made changes.

* Updated to reflect changes

---------

Co-authored-by: nathan <nathan@castaldifamily.com>
2026-04-03 13:39:53 -04:00
36a34876d7 feat(Workday): add cross-team access request draft and conversation playbook for AD sync initiative 2026-04-03 12:39:45 -04:00
aa7238889e refactor(workday): finalize modular structure and verify triple-tool suite (WIS-011, WIS-020) 2026-04-03 11:54:40 -04:00
2d96e0fc89 Refactor to address Type Hint from Pylance 2026-04-03 10:53:00 -04:00
e0001bed16 feat(workday): implement global manager mismatch scanner (WIS-017, WIS-020) 2026-04-03 10:51:17 -04:00
829d8fcfff feat(workday): enhance worker status retrieval and add manager resolution tool 2026-04-03 10:48:41 -04:00
7e00f3026c Refactored to resolve type-hints from Pylance 2026-04-03 10:28:30 -04:00
330338cbb8 feat(workday): implement structured worker status tool (WIS-007, WIS-009) 2026-04-03 09:58:08 -04:00
2a62e51347 Updated folder structure 2026-04-03 09:32:41 -04:00
9eaa13b923 docs(workday): add sync backlog and sprint board
- Add execution planning artifacts in workday-ad-identity-sync-next-steps.md and workday-ad-identity-sync-sprint-board.md.
- Capture the why from current staged context by turning identified Workday sync blockers and delivery sequencing into a prioritized backlog and sprint-ready board; no SESSION_SNAPSHOT file was found in documentation/project-history for additional session intent.
2026-04-03 09:07:55 -04:00
96a04e6535 Added current MCP working files 2026-03-27 15:26:14 -04:00